diff options
| author | Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> | 2017-02-03 21:57:42 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2017-02-05 15:20:02 +0100 |
| commit | bd8b531d24431141a919daf6c50cca7de8547023 (patch) | |
| tree | a159789e0a111c6b384a42d80bcab6ea4145d710 /support | |
| parent | ff28d37dfa1b961f438c007f81b6b8d28f1f2624 (diff) | |
graph-depends: avoid use of global var 'rule' in get_depends
Function get_depends was recently changed to support both normal
dependencies as reverse dependencies, via a global variable 'rule' that
equals 'show-depends' or 'show-rdepends'.
As a subsequent function will extract this function get_depends to a
separate file, the use of globals is problematic.
Instead, pass the global as an argument.
Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'support')
| -rwxr-xr-x | support/scripts/graph-depends | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends index c3c97cb38..095619a27 100755 --- a/support/scripts/graph-depends +++ b/support/scripts/graph-depends @@ -161,7 +161,7 @@ def get_targets(): # Execute the "make <pkg>-show-depends" command to get the list of # dependencies of a given list of packages, and return the list of # dependencies formatted as a Python dictionary. -def get_depends(pkgs): +def get_depends(pkgs, rule): sys.stderr.write("Getting dependencies for %s\n" % pkgs) cmd = ["make", "-s", "--no-print-directory" ] for pkg in pkgs: @@ -204,7 +204,7 @@ def get_all_depends(pkgs): if len(filtered_pkgs) == 0: return [] - depends = get_depends(filtered_pkgs) + depends = get_depends(filtered_pkgs, rule) deps = set() for pkg in filtered_pkgs: |