summaryrefslogtreecommitdiff
path: root/benchmarks
diff options
context:
space:
mode:
authorPetri Latvala <petri.latvala@intel.com>2019-01-16 13:20:41 +0200
committerPetri Latvala <petri.latvala@intel.com>2019-01-21 13:51:01 +0200
commit72964897ce92525ea62e1e1b1b7df24b6c6125dd (patch)
tree18326259826cfe20539a40bdccd5dfdb2954283e /benchmarks
parentbccb4a1e3360523315a415a2d3acfd7f9c90133c (diff)
benchmarks/gem_userptr_benchmark: Correctly free memory
if (p) free(p) does a useless check, free(NULL) is a valid call. Also assign NULL so we don't end up double-freeing memory if anyone reorders nr_bos to have a 0 after other values. Signed-off-by: Petri Latvala <petri.latvala@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Diffstat (limited to 'benchmarks')
-rw-r--r--benchmarks/gem_userptr_benchmark.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/benchmarks/gem_userptr_benchmark.c b/benchmarks/gem_userptr_benchmark.c
index f7716dfa..bef2ccc4 100644
--- a/benchmarks/gem_userptr_benchmark.c
+++ b/benchmarks/gem_userptr_benchmark.c
@@ -355,8 +355,9 @@ static void test_impact_overlap(int fd, const char *prefix)
for (i = 0; i < nr_bos[subtest]; i++)
gem_close(fd, handles[i]);
- if (block)
- free(block);
+
+ free(block);
+ block = NULL;
}
}