diff options
author | Petri Latvala <petri.latvala@intel.com> | 2019-01-18 12:42:10 +0200 |
---|---|---|
committer | Petri Latvala <petri.latvala@intel.com> | 2019-01-21 13:49:11 +0200 |
commit | 08822179e5e9d7ee7e76e1c912e45193f38c8cd7 (patch) | |
tree | 38df2286a93e7914bdd80e13e354703052bff8b0 /lib/i915 | |
parent | 5b4485f55b0336e2b39e30b6bb187c41b63b52f5 (diff) |
lib/i915/gem_context: Help static analysis with execution flow
If an igt_ioctl fails, errno is set to non-zero, and static analysis
doesn't quite get it. Add an igt_assume() to help.
v2: Braces on both branches of an if (Chris)
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: MichaĆ Winiarski <michal.winiarski@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'lib/i915')
-rw-r--r-- | lib/i915/gem_context.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/i915/gem_context.c b/lib/i915/gem_context.c index 669bd318..16004685 100644 --- a/lib/i915/gem_context.c +++ b/lib/i915/gem_context.c @@ -80,10 +80,12 @@ int __gem_context_create(int fd, uint32_t *ctx_id) int err = 0; memset(&create, 0, sizeof(create)); - if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) == 0) + if (igt_ioctl(fd, DRM_IOCTL_I915_GEM_CONTEXT_CREATE, &create) == 0) { *ctx_id = create.ctx_id; - else - err = -errno; + } else { + err = -errno; + igt_assume(err != 0); + } errno = 0; return err; |