diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2017-08-25 18:28:36 +0100 |
---|---|---|
committer | Arkadiusz Hiler <arkadiusz.hiler@intel.com> | 2017-08-30 12:54:08 +0300 |
commit | f65a718019056d2f5b1612161042fcea0b6754eb (patch) | |
tree | 72c120d38861b5fa99f727919b4d13334ed7121c /lib/igt_kmod.c | |
parent | 1b6585eeb22a2787fa52b2a192d4e9539acbd9c6 (diff) |
lib/kmod: Fix error reporting for kmod load/unload
A "return -err ? err < 0 : err" managed to slip through. So if err was
set, we returned 0 or 1 based on sign, or 0 if err was zero.
If err is negative, we want treat it as an error, so report it back
to the caller, all other values were a success, so convert those to 0.
This should actually be no functional change, as all errors were
reported as 1, and everything else as 0.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Diffstat (limited to 'lib/igt_kmod.c')
-rw-r--r-- | lib/igt_kmod.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c index b366adeb..26691e30 100644 --- a/lib/igt_kmod.c +++ b/lib/igt_kmod.c @@ -155,7 +155,7 @@ igt_kmod_load(const char *mod_name, const char *opts) } out: kmod_module_unref(kmod); - return -err ? err < 0 : err; + return err < 0 ? err : 0; } @@ -192,7 +192,7 @@ igt_kmod_unload(const char *mod_name, unsigned int flags) out: kmod_module_unref(kmod); - return -err ? err < 0 : err; + return err < 0 ? err : 0; } /** |