diff options
| author | Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> | 2017-04-18 15:56:17 +0300 |
|---|---|---|
| committer | Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> | 2017-05-10 09:36:25 +0300 |
| commit | 15ffbf378c3d9b3a75ac6b6ec6d96f917e9a7637 (patch) | |
| tree | 71e68d685b37017d024705b58d2fbcaf1226b963 /lib/igt_kms.c | |
| parent | 5a6b9754abefeaa65694adfc045948e99f9be06d (diff) | |
lib/igt_kms: Force outputs to use full range RGB
In at least SKL and GLK (possibly other devices too), using a cursor
plane to scan out an fb might result in a different pipe crc than when
using a regular plane at the same position with the same fb while using
the CSC logic to limit the color range. The differences could be caused
by the cursor plane being limited to 8 bpc while the regular planes
support higher bit depths, leading to slightly different values to be
used internally. This is evidenced by the failures happening with
specific color values, 0.5 for example, but that's mostly speculation.
To avoid misterious failures caused by limited range rgb, force all
tests to use full range. It is still possible for tests to override this
if necessary.
v2: Add more details to the commit message.
v3: Force all tests to use full range.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Diffstat (limited to 'lib/igt_kms.c')
| -rw-r--r-- | lib/igt_kms.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 9bfa0e1d..c77716b4 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1571,10 +1571,15 @@ static void igt_output_refresh(igt_output_t *output) -1); } - if (output->config.connector) + if (output->config.connector) { igt_atomic_fill_connector_props(display, output, IGT_NUM_CONNECTOR_PROPS, igt_connector_prop_names); + kmstest_set_connector_broadcast_rgb(display->drm_fd, + output->config.connector, + BROADCAST_RGB_FULL); + } + if (output->use_override_mode) output->config.default_mode = output->override_mode; |