diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2015-02-05 16:12:11 +0200 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2015-03-24 15:30:20 +0200 |
| commit | 0a3ef582daa961047dabf3008177f60db8984b03 (patch) | |
| tree | 97b45ed0cf7335b8dc97933e04ae1800ce4b0b1b /lib/intel_iosf.c | |
| parent | 06a9c3566462e04d47c3006daeb4ff0c89c5d043 (diff) | |
lib: Change IOSF SB devfn to 0.0
The devfn field in the IOSF SB messages is only relevant when there's a
real PCI bus or some other multifunction device behind a single port.
Otherwise the port number itself is enough to uniquely identify the
target. In fact some IOSF SB targets reject the access when devfn is not
0.0 (eg. GPIO_NC on BYT).
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Diffstat (limited to 'lib/intel_iosf.c')
| -rw-r--r-- | lib/intel_iosf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/intel_iosf.c b/lib/intel_iosf.c index 27134a07..01577cd0 100644 --- a/lib/intel_iosf.c +++ b/lib/intel_iosf.c @@ -28,7 +28,7 @@ static int vlv_sideband_rw(uint32_t port, uint8_t opcode, uint32_t addr, bar = 0; be = 0xf; - devfn = 16; + devfn = 0; cmd = (devfn << IOSF_DEVFN_SHIFT) | (opcode << IOSF_OPCODE_SHIFT) | (port << IOSF_PORT_SHIFT) | (be << IOSF_BYTE_ENABLES_SHIFT) | |