diff options
| author | Katarzyna Dec <katarzyna.dec@intel.com> | 2018-04-11 10:14:58 +0200 |
|---|---|---|
| committer | Arkadiusz Hiler <arkadiusz.hiler@intel.com> | 2018-04-12 23:56:40 +0300 |
| commit | 081f77178f9821cf39e238452700562561ce2eb2 (patch) | |
| tree | 28a0b6636a41c19b63b0029c12b0ac4bc9d38292 /lib/meson.build | |
| parent | aa330c72a74c071eddb35300e4dd1957eb8d30ff (diff) | |
lib: Move common gpgpu/media fill functions to gpu_fill library
Gpgpu_fill and media_fill libraries are very similar and many
functions can be shared. I have created library gpu_fill with
all functions needed for implementing gpgpu_fill and media_fill
tests for all Gens. For reviewing and debugging purposes this patch
should be only moving functions from few libraries to one removing
functions identical for both media and gpgpu.
Places in the code that required more changes:
Removing gen7_fill_gpgpu_kernel function that is identical to
gen7_fill_media_kernel and introduces conflict with moving
genX_fill_interface_descriptor, which are the same for media and gpgpu.
Function gen8_fill_media_kernel is not removed in this patch
(although it is identical with gen7 version), because this patch
should be as much as possible functions movement.
gen8_fill_interface_descriptor was unified for media and gpgpu
by adding kernel and its size as a parameter (this parameters
were missing in media gen8, gen8lp and gen9 functions)
gen8_emit_state_base_address was unified, the one for gpgpu was
configured like it would be using indirect state (while we are
using CURBE). I have checked that media fill version
(OUT_BATCH(0 | BASE_ADDRESS_MODIFY)) works fine on gpgpu gen8 and newer.
v2: Changed code layout. GenX_fill_media_kernel was identical to
genX_fill_gpgpu_kernel so this function was unified to
gen7_fill_kernel. There were 2 very similar functions
gen8_emit_state_base_address for media and gpgpu, where the one
for gpgpu was configured like it would be using indirect state
(while we are using CURBE). I have checked if media fill version
works fine in gpgpu test on Gen8 and unified them.
v3: Made patch easier for reviewing moving changes unifying code for
various gens (that were included v1) to other patch, leaving only
the most critical code changes.
v5: Added copyrights and #ifndef to gpu_fill.h
v5: Added copyrights to gpu_fill.c
Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
Diffstat (limited to 'lib/meson.build')
| -rw-r--r-- | lib/meson.build | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/meson.build b/lib/meson.build index b3b8b14a..385e08b9 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -30,6 +30,7 @@ lib_sources = [ 'media_fill_gen9.c', 'media_spin.c', 'gpgpu_fill.c', + 'gpu_fill.c', 'rendercopy_i915.c', 'rendercopy_i830.c', 'rendercopy_gen6.c', |