summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2014-03-12 19:00:48 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-03-12 21:22:48 +0100
commit803d07b2fff95794d8a840728d417e8e1d31264c (patch)
tree6b699f6ee5177d1a7415d3dbcadca053af277f5b /lib
parent096bb851f6bbcd018b3e7dc42930952971c4ea72 (diff)
lib: make igt_debugfs_open infallible
(Almost) no one cared anyway. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'lib')
-rw-r--r--lib/igt_debugfs.c13
-rw-r--r--lib/igt_debugfs.h2
2 files changed, 7 insertions, 8 deletions
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index 32edc435..9c4c989c 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -37,7 +37,7 @@
/*
* General debugfs helpers
*/
-int igt_debugfs_init(igt_debugfs_t *debugfs)
+void igt_debugfs_init(igt_debugfs_t *debugfs)
{
const char *path = "/sys/kernel/debug";
struct stat st;
@@ -51,11 +51,9 @@ int igt_debugfs_init(igt_debugfs_t *debugfs)
if (stat("/sys/kernel/debug/dri", &st) == 0)
goto find_minor;
- if (stat("/sys/kernel/debug", &st))
- return errno;
+ igt_assert(stat("/sys/kernel/debug", &st) == 0);
- if (mount("debug", "/sys/kernel/debug", "debugfs", 0, 0))
- return errno;
+ igt_assert(mount("debug", "/sys/kernel/debug", "debugfs", 0, 0) == 0);
find_minor:
strcpy(debugfs->root, path);
@@ -64,12 +62,13 @@ find_minor:
sprintf(debugfs->dri_path + len, "/i915_error_state");
if (stat(debugfs->dri_path, &st) == 0) {
debugfs->dri_path[len] = '\0';
- return 0;
+ return;
}
}
debugfs->dri_path[0] = '\0';
- return ENOENT;
+
+ igt_fail(4);
}
int igt_debugfs_open(igt_debugfs_t *debugfs, const char *filename, int mode)
diff --git a/lib/igt_debugfs.h b/lib/igt_debugfs.h
index 43fa0fc5..5f940cb2 100644
--- a/lib/igt_debugfs.h
+++ b/lib/igt_debugfs.h
@@ -36,7 +36,7 @@ typedef struct {
char dri_path[128];
} igt_debugfs_t;
-int igt_debugfs_init(igt_debugfs_t *debugfs);
+void igt_debugfs_init(igt_debugfs_t *debugfs);
int igt_debugfs_open(igt_debugfs_t *debugfs, const char *filename, int mode);
FILE *igt_debugfs_fopen(igt_debugfs_t *debugfs, const char *filename,
const char *mode);