diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2019-02-18 12:25:50 +0000 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2019-03-26 10:31:05 +0000 |
| commit | 2551ed1864985d2fe1c250337f86c7b2bc670c67 (patch) | |
| tree | 41e7a5f6b1e1f679f01a190aa8365facf1cf23b9 /tests/i915 | |
| parent | abffc52b0ec74c8498f2197760199a54e29c8a6a (diff) | |
i915/gem_ctx_param: Remove kneecapping
The invalid set/get tests do not serve the purpose of detecting whether
or not invalid parameters are indeed detected correctly -- simply because
the kernel is the arbiter of what is invalid and this test second
guesses that and is wrong.
The intent of this test was to ensure that we didn't include any holes
in the parameter space that may have been used for nefarious undisclosed
purposes, i.e. the maintainer's job backed up by reviewers.
As proving no holes is impossible without fuzzing/exhaustive search and
a whitelist, accept defeat and just check whether the very last
parameter (which should be unused for a long, long time) is invalid.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Diffstat (limited to 'tests/i915')
| -rw-r--r-- | tests/i915/gem_ctx_param.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c index acc1e629..b6f57236 100644 --- a/tests/i915/gem_ctx_param.c +++ b/tests/i915/gem_ctx_param.c @@ -296,11 +296,7 @@ igt_main /* I915_CONTEXT_PARAM_SSEU tests are located in gem_ctx_sseu.c */ - /* NOTE: This testcase intentionally tests for the next free parameter - * to catch ABI extensions. Don't "fix" this testcase without adding all - * the tests for the new param first. - */ - arg.param = I915_CONTEXT_PARAM_SSEU + 1; + arg.param = -1; /* Should be safely unused for a while */ igt_subtest("invalid-param-get") { arg.ctx_id = ctx; |