diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2018-01-30 17:44:14 +0200 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2018-01-30 18:55:51 +0200 |
| commit | 3f820260ce660cdff7fb803237c57554a29498c0 (patch) | |
| tree | 0ef330c5428e400e80d413dfc35778c3e8ef3601 /tests/kms_atomic_transition.c | |
| parent | 098a4013434dafda61fa47bde08c29b36f436e9b (diff) | |
tests/kms_atomic_transition: Don't abuse the HSKEW flag to force a modeset
Since kernel commit e995ca0b8139 ("drm/i915: Provide a device level
.mode_valid() hook") i915 will bluntly reject the HSKEW mode flag. Thus
we can't abuse it to force a modeset.
Since we don't particularly care about the visual results here we can
risk making the display unhappy by eg. flipping the hsync polarity
instead.
Also add a comment documenting why we're doing this.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104848
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Diffstat (limited to 'tests/kms_atomic_transition.c')
| -rw-r--r-- | tests/kms_atomic_transition.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index 79863939..aa9a6f84 100644 --- a/tests/kms_atomic_transition.c +++ b/tests/kms_atomic_transition.c @@ -410,7 +410,8 @@ run_transition_test(igt_display_t *display, enum pipe pipe, igt_output_t *output mode = igt_output_get_mode(output); override_mode = *mode; - override_mode.flags |= DRM_MODE_FLAG_HSKEW; + /* try to force a modeset */ + override_mode.flags ^= DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NHSYNC; igt_create_fb(display->drm_fd, mode->hdisplay, mode->vdisplay, DRM_FORMAT_XRGB8888, LOCAL_DRM_FORMAT_MOD_NONE, &fb); |