diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-02-27 22:04:18 +0100 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2015-03-23 11:02:28 +0100 |
commit | 562bbe12f6fb75811a746c742a28d32a17b26aa9 (patch) | |
tree | 1a833996699b9d61c272f262bfd4159f00b82079 /tests/kms_pipe_crc_basic.c | |
parent | e588f6dfa6f022120d5a55ef96994dbbc33d0dc9 (diff) |
tests: Remove usage of igt_crc_equal and _non_null
Tests should positively check for crc matches, not for mismatches.
Enforce this by only exposing and igt_assert function for comparing
crcs.
For the few tests which didn't just do this as consistency checks but
to do functional tests add FIXME comments that some reference crc
values are missing.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'tests/kms_pipe_crc_basic.c')
-rw-r--r-- | tests/kms_pipe_crc_basic.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 66e7b6cd..2b69f688 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -168,18 +168,6 @@ test_read_crc_for_output(data_t *data, int pipe, igt_output_t *output, igt_debug("CRC for this fb: %s\n", crc_str); free(crc_str); - /* - * make sure the CRC of this fb is different from the ones of - * previous fbs - */ - for (j = 0; j < c; j++) - igt_assert(!igt_crc_equal(&colors[j].crc, - &colors[c].crc)); - - /* ensure the CRCs are not all 0s */ - for (j = 0; j < N_CRCS; j++) - igt_assert(!igt_crc_is_null(&crcs[j])); - /* and ensure that they'are all equal, we haven't changed the fb */ for (j = 0; j < (N_CRCS - 1); j++) igt_assert_crc_equal(&crcs[j], &crcs[j + 1]); |