diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-11-22 12:37:02 +0000 |
|---|---|---|
| committer | Chris Wilson <chris@chris-wilson.co.uk> | 2016-11-25 12:22:29 +0000 |
| commit | eaa1c907e9abf8350273f6dbfd2d3115b52ba272 (patch) | |
| tree | d77d9cdaddfebe30f86d238dec132b46b6062370 /tests/kms_setmode.c | |
| parent | 17ad08e9e0db2b04adaddb6a25594b8b25a0fcbd (diff) | |
igt/kms_setmode: Adjust timing assertion from percentage to scanline
The target is that we report the vblank time accurate to within a
scanline (limit of the hw with which we can reliably compensate).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'tests/kms_setmode.c')
| -rw-r--r-- | tests/kms_setmode.c | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index 9dafca00..e1e18939 100644 --- a/tests/kms_setmode.c +++ b/tests/kms_setmode.c @@ -417,6 +417,11 @@ static double frame_time(const drmModeModeInfo *kmode) return 1000.0 * kmode->htotal * kmode->vtotal / kmode->clock; } +static double line_time(const drmModeModeInfo *kmode) +{ + return 1000.0 * kmode->htotal / kmode->clock; +} + static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) { #define CALIBRATE_TS_STEPS 120 /* ~2s has to be less than 128! */ @@ -425,6 +430,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) uint32_t last_seq; uint64_t last_timestamp; double expected; + double accuracy; double mean; double stddev; int n; @@ -470,15 +476,21 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) mean = igt_stats_get_mean(&stats); stddev = igt_stats_get_std_deviation(&stats); + accuracy = 3.090 * stddev; /* 2-tailed 99% confidence */ + + igt_info("Expected frametime: %.0fus; measured %.1fus +- %.3fus accuracy %.2f%% [%.2f scanlines]\n", + expected, mean, stddev, + 100 * accuracy / mean, accuracy / line_time(kmode)); - igt_info("Expected frametime: %.0fus; measured %.1fus +- %.3fus accuracy %.2f%%\n", - expected, mean, stddev, 100 * 6 * stddev / mean); - igt_assert(6 * stddev / mean < 0.005); /* 99% accuracy within 0.5% */ + /* 99% accuracy within one scanline */ + igt_assert_f(accuracy < line_time(kmode), + "vblank accuracy (%.3fus, %.1f%%) worse than a scanline (%.3fus)\n", + accuracy, 100 * accuracy / mean, line_time(kmode)); igt_assert_f(fabs(mean - expected) < 2*stddev, - "vblank interval differs from modeline! expected %.1fus, measured %1.fus +- %.3fus, difference %.1fus (%.1f sigma)\n", - expected, mean, stddev, - fabs(mean - expected), fabs(mean - expected) / stddev); + "vblank interval differs from modeline! expected %.1fus, measured %1.fus +- %.3fus, difference %.1fus (%.1f sigma)\n", + expected, mean, stddev, + fabs(mean - expected), fabs(mean - expected) / stddev); } static void test_crtc_config(const struct test_config *tconf, |