diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-07-10 20:04:19 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-07-10 20:06:54 +0200 |
| commit | 282482db70188a3cbc653cebbf407715373255d1 (patch) | |
| tree | 37133f637f634c792b3eb9861d4d5d261e2b0192 /tests/kms_universal_plane.c | |
| parent | 329f7a3734331cb57895a675d4fc87c261f338bd (diff) | |
tests: Run igt.cocci
New stuff caught.
Plus manually simplify the massive igt_fail_on_f(file == NULL, ...) to
a simple igt_assert(file). We already print the errno (if
applicapable) and the condition, which is equally informative.
Cc: Yi Sun <yi.sun@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Wendy Wang <wendy.wang@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'tests/kms_universal_plane.c')
| -rw-r--r-- | tests/kms_universal_plane.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c index c64cdbb9..94d89b87 100644 --- a/tests/kms_universal_plane.c +++ b/tests/kms_universal_plane.c @@ -62,9 +62,8 @@ functional_test_init(functional_test_t *test, igt_output_t *output, enum pipe pi drmModeModeInfo *mode; test->pipe_crc = igt_pipe_crc_new(pipe, INTEL_PIPE_CRC_SOURCE_AUTO); - if (!test->pipe_crc) - igt_skip("auto crc not supported on this connector with pipe %i\n", - pipe); + igt_skip_on_f(!test->pipe_crc, + "auto crc not supported on this connector with pipe %i\n", pipe); igt_output_set_pipe(output, pipe); @@ -136,8 +135,7 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output) igt_assert(data->display.has_universal_planes); igt_skip_on(pipe >= display->n_pipes); - fprintf(stdout, "Testing connector %s using pipe %c\n", - igt_output_name(output), pipe_name(pipe)); + igt_info("Testing connector %s using pipe %c\n", igt_output_name(output), pipe_name(pipe)); functional_test_init(&test, output, pipe); |