diff options
author | Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> | 2018-05-09 10:37:38 -0700 |
---|---|---|
committer | Petri Latvala <petri.latvala@intel.com> | 2018-05-15 10:32:57 +0300 |
commit | b6de14f7211e852800f3abf99f210bde3c1167c6 (patch) | |
tree | 98cc829c3125de54c6efc2f402115455fabf5eb7 /tests | |
parent | 1b680def39a50fd5877326a877a21ce1a398453f (diff) |
tests/psr: Optimize check for green frame.
Eliminate three memcpy's and four sscanf's.
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/kms_psr_sink_crc.c | 30 |
1 files changed, 5 insertions, 25 deletions
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index af63e689..94134b7d 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/kms_psr_sink_crc.c @@ -241,34 +241,14 @@ static void get_sink_crc(data_t *data, char *crc) static bool is_green(char *crc) { - char color_mask[5] = "FFFF\0"; - char rs[5], gs[5], bs[5]; - unsigned int rh, gh, bh, mask; - int ret; - + const char *mask = "0000FFFF0000"; + uint32_t *p = (uint32_t *)crc, *mask_p = (uint32_t *)mask; if (igt_interactive_debug) return false; - sscanf(color_mask, "%4x", &mask); - - memcpy(rs, &crc[0], 4); - rs[4] = '\0'; - ret = sscanf(rs, "%4x", &rh); - igt_require(ret > 0); - - memcpy(gs, &crc[4], 4); - gs[4] = '\0'; - ret = sscanf(gs, "%4x", &gh); - igt_require(ret > 0); - - memcpy(bs, &crc[8], 4); - bs[4] = '\0'; - ret = sscanf(bs, "%4x", &bh); - igt_require(ret > 0); - - return ((rh & mask) == 0 && - (gh & mask) != 0 && - (bh & mask) == 0); + /* Check R and B components are 0 and G is non-zero */ + return *p == *mask_p && *(p + 2) == *(mask_p + 2) && + (*(p + 1) & *(mask_p + 1)) != 0; } static void assert_or_manual(bool condition, const char *expected) |