diff options
author | Ben Widawsky <ben@bwidawsk.net> | 2012-08-30 14:17:01 -0700 |
---|---|---|
committer | Ben Widawsky <ben@bwidawsk.net> | 2012-08-30 14:20:52 -0700 |
commit | bc62567b77cd3a790e2e8e2d7fd81ce950bfbe3f (patch) | |
tree | e6b64d527f5eb6024ba9c374c8e1e9922a6ff7ac /tools | |
parent | 54ed938d393970584a9b2a8b0783b0c0901255db (diff) |
clang: Fix static analysis warnings from clang
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/intel_forcewaked.c | 5 | ||||
-rw-r--r-- | tools/intel_gpu_top.c | 2 | ||||
-rw-r--r-- | tools/intel_infoframes.c | 12 | ||||
-rw-r--r-- | tools/intel_reg_dumper.c | 2 |
4 files changed, 10 insertions, 11 deletions
diff --git a/tools/intel_forcewaked.c b/tools/intel_forcewaked.c index 3ab2d6f8..a90e73e0 100644 --- a/tools/intel_forcewaked.c +++ b/tools/intel_forcewaked.c @@ -89,8 +89,9 @@ int main(int argc, char *argv[]) if (!is_alive()) { INFO_PRINT("gpu reset? restarting daemon\n"); intel_register_access_fini(); - ret = intel_register_access_init(intel_get_pci_device(), - 1); + ret = intel_register_access_init(intel_get_pci_device(), 1); + if (ret) + INFO_PRINT("Reg access init fail\n"); } sleep(1); } diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index e561865c..76a2b0bb 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -466,8 +466,6 @@ int main(int argc, char **argv) break; } } - argc -= optind; - argv += optind; pci_dev = intel_get_pci_device(); devid = pci_dev->device_id; diff --git a/tools/intel_infoframes.c b/tools/intel_infoframes.c index f5a40067..d74df645 100644 --- a/tools/intel_infoframes.c +++ b/tools/intel_infoframes.c @@ -381,7 +381,7 @@ static void dump_raw_infoframe(DipInfoFrame *frame) static void dump_avi_info(Transcoder transcoder) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipFrequency freq; DipInfoFrame frame; @@ -427,7 +427,7 @@ static void dump_avi_info(Transcoder transcoder) static void dump_vendor_info(Transcoder transcoder) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipFrequency freq; DipInfoFrame frame; @@ -453,7 +453,7 @@ static void dump_vendor_info(Transcoder transcoder) static void dump_gamut_info(Transcoder transcoder) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipFrequency freq; DipInfoFrame frame; @@ -479,7 +479,7 @@ static void dump_gamut_info(Transcoder transcoder) static void dump_spd_info(Transcoder transcoder) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipFrequency freq; DipInfoFrame frame; char vendor[9]; @@ -660,7 +660,7 @@ static int parse_infoframe_option_s(const char *name, const char *s, static void change_avi_infoframe(Transcoder transcoder, char *commands) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipInfoFrame frame; char option[32]; uint32_t option_val; @@ -760,7 +760,7 @@ static void change_avi_infoframe(Transcoder transcoder, char *commands) static void change_spd_infoframe(Transcoder transcoder, char *commands) { Register reg = get_dip_ctl_reg(transcoder); - uint32_t val = INREG(reg); + uint32_t val; DipInfoFrame frame; char option[16]; char option_val_s[32]; diff --git a/tools/intel_reg_dumper.c b/tools/intel_reg_dumper.c index b49d967b..7564cae0 100644 --- a/tools/intel_reg_dumper.c +++ b/tools/intel_reg_dumper.c @@ -2158,7 +2158,7 @@ intel_dump_other_regs(void) } else { n = ((fp >> 16) & 0x3f); m2 = ((fp >> 0) & 0x3f); - m = 5 * (m1 + 2) + (m2 + 2); + //m = 5 * (m1 + 2) + (m2 + 2); dot = (ref * (5 * (m1 + 2) + (m2 + 2)) / (n + 2)) / (p1 * p2); |