summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2018-11-26 11:08:24 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2018-11-26 15:26:14 +0100
commitde775f3a15daebcf191562fa0984f49497b76fd0 (patch)
tree0d65008273c1c04226547a74fa7e915ae2e60b99 /tools
parentf48bebb15d3d2c1e6382e1f11b0aeac06fae6082 (diff)
tests: close(fd) without igt_fixture considered harmful
Some tests assume that close on an unopened fd is fine, except it's not just unopened but actually stack garbage. There's a good chance we end up running close(0), which wreaks the testcase enumeration. Fix this. Reviewed-by: Jani Nikula <jani.nikula@intel.com> Not sure there's a better way to catch this than git grep plus lots of manual auditing ... The unit tests only catch it by accident (x86 works fine, I hit it in one testcase only cross-building to aarch64). v2: Note that gem_pread_after_blit uses heap memory, so is actually guaranteed to run close(0). Noticed by Jani. Reviewed-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions