diff options
| author | Jani Nikula <jani.nikula@intel.com> | 2017-09-21 16:28:48 +0300 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2017-10-20 16:15:19 +0300 |
| commit | ee7a0fe41c0425fddd5d7a613152907827cc92d7 (patch) | |
| tree | 5f73c4daf7ff5556608b296b8e07aabcb36541b7 /tools | |
| parent | 48bf7bc0a3ba35236c3f5ceca3188aac67cd637b (diff) | |
tools/intel_vbt_decode: use %.*s instead of duplicating a string
child->device_id may not be terminated, but we can use %.*s format
specifier to define the max length to print. No need to make a copy.
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/intel_vbt_decode.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c index 4865f0ba..0f7e2daf 100644 --- a/tools/intel_vbt_decode.c +++ b/tools/intel_vbt_decode.c @@ -388,19 +388,15 @@ static void dump_child_device(struct context *context, const struct child_device_config *child) { const struct child_device_config *efp = child; - char child_id[11]; if (!child->device_type) return; if (context->bdb->version < 152) { - strncpy(child_id, (const char *)child->device_id, 10); - child_id[10] = 0; - printf("\tChild device info:\n"); printf("\t\tDevice type: %04x (%s)\n", child->device_type, child_device_type(child->device_type)); - printf("\t\tSignature: %s\n", child_id); + printf("\t\tSignature: %.*s\n", (int)sizeof(child->device_id), child->device_id); printf("\t\tAIM offset: %d\n", child->addin_offset); printf("\t\tDVO port: 0x%02x\n", child->dvo_port); } else { /* 152+ have EFP blocks here */ |