diff options
| author | Ben Warren <biggerbadderben@gmail.com> | 2008-01-09 18:15:53 -0500 |
|---|---|---|
| committer | Wolfgang Denk <wd@denx.de> | 2008-01-10 01:06:02 +0100 |
| commit | 422b1a01602b6e2fbf8444a1192c7ba31461fd4c (patch) | |
| tree | e8891bc2519ddd636e32fe2b42945786dbce1f44 /drivers/qe | |
| parent | d3a6532cbe263d992f49e86ac95bede28e96f9c8 (diff) | |
Fix Ethernet init() return codes
Change return values of init() functions in all Ethernet drivers to conform
to the following:
>=0: Success
<0: Failure
All drivers going forward should return 0 on success. Current drivers that
return 1 on success were left as-is to minimize changes.
Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
Acked-by: Stefan Roese <sr@denx.de>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Acked-by: Kim Phillips <kim.phillips@freescale.com>
Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Acked-By: Timur Tabi <timur@freescale.com>
Diffstat (limited to 'drivers/qe')
| -rw-r--r-- | drivers/qe/uec.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c index a27c12aa2..44cbea578 100644 --- a/drivers/qe/uec.c +++ b/drivers/qe/uec.c @@ -1129,7 +1129,7 @@ static int uec_init(struct eth_device* dev, bd_t *bd) if (dev->enetaddr[0] & 0x01) { printf("%s: MacAddress is multcast address\n", __FUNCTION__); - return 0; + return -1; } uec_set_mac_address(uec, dev->enetaddr); uec->the_first_run = 1; @@ -1138,10 +1138,10 @@ static int uec_init(struct eth_device* dev, bd_t *bd) err = uec_open(uec, COMM_DIR_RX_AND_TX); if (err) { printf("%s: cannot enable UEC device\n", dev->name); - return 0; + return -1; } - return uec->mii_info->link; + return (uec->mii_info->link ? 0 : -1); } static void uec_halt(struct eth_device* dev) |