diff options
| author | Tvrtko Ursulin <tvrtko.ursulin@intel.com> | 2018-09-12 10:33:05 +0100 |
|---|---|---|
| committer | Tvrtko Ursulin <tvrtko.ursulin@intel.com> | 2018-09-14 11:52:57 +0100 |
| commit | 468febc4c746f168e885e0d662ec3adb0cca60f6 (patch) | |
| tree | 43e3068c9869d0af34543582ac8e2c98b1365962 | |
| parent | 74dc0538de74e550f7e6d8b576051a0238f2b14e (diff) | |
intel: Be consistent with test results on simulation
Tests which call intel_require_memory currently always skip on simulation,
unless they fail first due insufficient memory. This can create different
outcomes depending on the simulation environment so move the simulation
skip to the start of the function for 100% consistency in results.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
| -rw-r--r-- | lib/intel_os.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/intel_os.c b/lib/intel_os.c index 29a27272..e1e31e23 100644 --- a/lib/intel_os.c +++ b/lib/intel_os.c @@ -375,6 +375,8 @@ void intel_require_memory(uint64_t count, uint64_t size, unsigned mode) uint64_t required, total; bool sufficient_memory; + igt_skip_on_simulation(); + sufficient_memory = __intel_check_memory(count, size, mode, &required, &total); if (!sufficient_memory) { @@ -406,8 +408,6 @@ void intel_require_memory(uint64_t count, uint64_t size, unsigned mode) mode & (CHECK_RAM | CHECK_SWAP) ? "RAM" : "", mode & CHECK_SWAP ? " + swap": "", (long long)vfs_file_max()); - - igt_skip_on_simulation(); } void intel_purge_vm_caches(int drm_fd) |