diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-02-13 11:35:46 +0100 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-02-15 10:36:40 +0100 |
commit | 89932c1500f927165c243015d70318f5cf3082da (patch) | |
tree | cb18a7d48c9175448de90c1fcdfb85dff5e6190c /include | |
parent | ecdf823b965f93269ccfc4ed89c4a06e13d3ff2c (diff) |
lib: Don't leak children in igt_waitchildren_timeout
Instead of cleaning up the mess in igt_exit make sure we don't even
let it out of the container. See also
commit 754876378d6c9b2775e8c07b4d16f9878c55949f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Fri Feb 26 22:11:10 2016 +0000
igt/gem_sync: Enforce a timeout of 20s
which added this helper.
To make sure that everyone follows the rules, add an assert.
We're keeping the cleanup code as a failsafe, and because it speeds
up the testcase I'm following up with.
v2: Chris pointed out that my original patch did nothing. Which I
didn't catch because my testcase was also broken. Unfortunately this
means we need to open code part of the waiting.
v3: The 2nd __igt_waitchildren() isn't necessary, __igt_waitchildren
recovers from EINTR already and keeps waiting (Chris Wilson).
v4: Change the timeout signal vs waitchildren logic to be race-free
(Chris). This changes the exit code for a timeout from
IGT_EXIT_FAILURE to SIGKILL + 128.
v5: Clarify the docs (Chris).
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions