diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-08-13 13:20:58 +0200 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-08-13 15:15:18 +0200 |
commit | 8f5387eb99b640771812d28a0b949aca729bf296 (patch) | |
tree | 4ccb29a62ff7c4f055cf18fe31c9482ad16ae698 /tests/gem_caching.c | |
parent | 5e25fcc285240353ab15bd4c3a0d0e02d970f45b (diff) |
tests: introduce igt_require
Since igt_skip has funny control flow we can abuse it and make it work
like a special kind of assert which automatically skips tests if a
requirement fails.
Note that in places where we have a less strict test which should
always succeed (e.g. ioctl works or isn't available) the igt_assert
should be place before the igt_require with the more strict
requirements. Otherwise we'll skip a test instead of properly failing
it.
Convert a few users of igt_skip over to igt_require to showcase its
use.
v2: s/gem_check_/gem_require_/ so that we consistently use "require"
to indicate magic check that can call igt_skip. Imo hiding the
igt_require for feature checks is ok, but for more traditional assert
like use cases an explicit igt_require might be better.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'tests/gem_caching.c')
-rw-r--r-- | tests/gem_caching.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/gem_caching.c b/tests/gem_caching.c index 52931c57..6af76fa2 100644 --- a/tests/gem_caching.c +++ b/tests/gem_caching.c @@ -117,7 +117,7 @@ int main(int argc, char **argv) fd = drm_open_any(); - gem_check_caching(fd); + gem_require_caching(fd); devid = intel_get_drm_devid(fd); if (IS_GEN2(devid)) /* chipset only handles cached -> uncached */ |