diff options
| author | Simon Ser <simon.ser@intel.com> | 2019-03-26 15:32:30 +0200 |
|---|---|---|
| committer | Antonio Argenziano <antonio.argenziano@intel.com> | 2019-03-26 15:33:38 -0700 |
| commit | 55192ddf19444767c039386cae6864d934b35930 (patch) | |
| tree | 7e1bf7f4c64f506cc729aea420994f82adb4226c /tests/kms_chamelium.c | |
| parent | a350b9f9f606296b1599c3617c8530a8985709e2 (diff) | |
tests/kms_chamelium: fix typo in check_analog_bridge
This function checks whether a port is an analog bridge. Analog
bridges provide their own EDID thus the vendor should be different
from "IGT".
There was a typo that made the function always return true for VGA
ports. The condition was essentially:
thing != 'I' || thing != 'T'
which is always true.
Apparently this didn't cause any harm, but it's probably better to fix
it anyway in case some tests were skipped and shouldn't.
Signed-off-by: Simon Ser <simon.ser@intel.com>
Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>
Diffstat (limited to 'tests/kms_chamelium.c')
| -rw-r--r-- | tests/kms_chamelium.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index c2090037..2dc1049d 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -199,7 +199,7 @@ check_analog_bridge(data_t *data, struct chamelium_port *port) /* Analog bridges provide their own EDID */ if (edid_vendor[0] != 'I' || edid_vendor[1] != 'G' || - edid_vendor[0] != 'T') + edid_vendor[2] != 'T') return true; return false; |