diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2017-03-14 19:32:08 +0200 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2017-03-15 17:55:30 +0200 |
| commit | d08d2635c8a8230f2831d3a336f570aa3a38fe68 (patch) | |
| tree | 854ff06dbdcac13d62ceb005b030997024c6047e /tests/kms_cursor_legacy.c | |
| parent | 32c4b69a9d18ad7ec62f3e656a08f3325fb942c9 (diff) | |
tests/kms_cursor_legacy: make_busy() before get_vblank()
VLV is a sloth and so doing anything extra between the first and last
get_vblank() is likely to increase the chance of failing the test.
Let's move the make_busy() stuff to happen before the first get_vblank()
to reduce the amount of work done there.
These tests are still failing quite often on my VLV, but that is mostly
caused by igt_kms's tendency to still re-read all the connector properties
and whatnot as part of the commit operation. I suspect that fixing that
would eliminate most of the spurious failures.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Diffstat (limited to 'tests/kms_cursor_legacy.c')
| -rw-r--r-- | tests/kms_cursor_legacy.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c index c7083a07..b048f4ac 100644 --- a/tests/kms_cursor_legacy.c +++ b/tests/kms_cursor_legacy.c @@ -613,13 +613,13 @@ static void basic_flip_cursor(igt_display_t *display, /* Bind the cursor first to warm up */ do_ioctl(display->drm_fd, DRM_IOCTL_MODE_CURSOR, &arg[0]); - /* Start with a synchronous query to align with the vblank */ - vblank_start = get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS); - busy = NULL; if (flags & BASIC_BUSY) busy = make_fb_busy(display->drm_fd, &fb_info); + /* Start with a synchronous query to align with the vblank */ + vblank_start = get_vblank(display->drm_fd, pipe, DRM_VBLANK_NEXTONMISS); + switch (order) { case FLIP_BEFORE_CURSOR: switch (mode) { |