| Age | Commit message (Collapse) | Author |
|---|
|
When opening a DRM debugfs file, locate the right path based on the
given DRM device FD.
This is needed so, in setups with more than one DRM device, any
operations on debugfs files affect the expected DRM device.
v2: - rebased and fixed new API additions
v3: - updated chamelium test, which was missed previously
- use the minor of the device for the debugfs path, not the major
- have a proper exit handler for calling igt_hpd_storm_reset with the
right device fd.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Robert Foss <robert.foss@collabora.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
VLV is a sloth and so doing anything extra between the first and last
get_vblank() is likely to increase the chance of failing the test.
Let's move the make_busy() stuff to happen before the first get_vblank()
to reduce the amount of work done there.
These tests are still failing quite often on my VLV, but that is mostly
caused by igt_kms's tendency to still re-read all the connector properties
and whatnot as part of the commit operation. I suspect that fixing that
would eliminate most of the spurious failures.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
|
|
Add changes reflecting the new support for dynamic number of planes per pipe.
Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
|
|
This is required for ILK style watermark programming, which currently
inserts an extra vblank wait. This allows the tests to pass on those
platforms.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This forces the cursor fastpath to be used. While at it, add -atomic
versions of the test to compare legacy pageflip vs atomic.
The nonblocking modeset test is changed slightly, due to cdclk changes
the page flip may be stalled so it's not useful to test it. Just test
that a queued page flip + nonblocking modeset works as intended and
there is no kernel spew.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Trying to run as many cursor updates during a nonblocking modeset won't
work, because both crtc's might be involved in the modeset. Instead
try to run as many cursor updates on both crtc's at the same time,
while trying to queue page flips in between.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This fixes the test on older platforms that don't have ARGB support.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Nail the cursor update thread to a single cpu, and run a idle busy loop
on the same cpu. This will force it to the highest cpu speed, which will
eliminate cpu speed variations and allows the test to pass.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Kept in the previous commit by accident.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Because in the ideal case we currently wait 50% of the time for every frame,
on some machines cpu scaling gets in the way when we idle a lot and will
cause the machine to throttle to a lower cpu speed. This causes a
failure because we may end up missing vblanks.
Work around this by only running for 1/4th of the time at max speed,
even on low cpu speeds it will be less likely to run into issues then.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This was running for 150 seconds before, reduce it to 25.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Some tests may wait a vblank on master. Instead of
failing the tests, allow them to succeed if 1 vblank
passed.
Also no longer warn if a page flip is missed, change it to
info instead. As long as no more than 25% of the vblanks are
missed the tests will pass.
Also fix nonblocking modeset vs cursor, which needs an array
of cursor argument. This was a nice buffer overrun before.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
cursor hiding
This way the tests will pass with the legacy cursor hack.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
In case of a nonblocking modeset, the cursor update should block for
the modeset to finish.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
It's more readable like this, and with the ifs it was a completely
separate test anyway.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
make_busy() already existed!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
This is a test for the issue exposed by 97888, we perform a busy
bo update followed by a cursor update.
The page flip and cursor update should complete without hanging,
and the new fb should not be flipped yet as a result of the cursor
update.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Suggested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
The essence of the basic test is that neither the cursor nor the
nonblocking flip stall the application of the next.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
On skylake there's a add_all_affected_planes call that will make
atomic commit use the old cursor state. Add a test that first does
a page flip then cursor update to expose the issue. The test currently
fails on the vblank wait, but that's a common issue affecting all the
tests.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Since we are experiencing too much noise in BAT from what just looks
like scheduling delays in inspecting the vblank, reduce the basic test
to the fundamentla: check that the cursor ioctl following the nonblocking
flip/modeset occurs within the same vblank. Hopefully, CI + debug builds
are fast enough to do get-vblank; flip; cursor; get-vblank within a
single vblank period.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
When vrefresh is 30 the tests run for twice as long, set it to
vrefresh to make the tests just as long anywhere
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This probably won't pass by design on platforms that need to reallocate
global resources like watermarks on gen9+, but it's a good test anyway.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Add a test that first shows the cursor on the first display, then
shows it on the second display. This exposes the watermark issues on
SKL.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Add -varying-size, where we change the size of the cursor between
64x64 to maxw x maxh, atomic-transitions, which alternates between
a full-screen sprite plane and a full-screen primary plane,
toggle, which toggles cursor visibility and
make sure cursor moves between updates. This is a visual indicator of
the tests working as intended.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This can happen on CHV, where you only have a output on pipe C.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
This lets us pick a nice testing pattern while the test runs and makes
sure that the cursor updates don't get nooped. It also tests the
atomic modeset path, if available.
Also make sure cursorX-vs-flipX has 2 separate connected outputs,
else the test is worthless.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
No real changes yet, only replaced output validation with
for_each_valid_output_on_pipe.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Apart from gem_create nothing depends on i915, so use the dumb api
instead.
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
|
|
Rename single-A-bo to pipe-A-single-bo, single-all-bo to
pipe-all-single-bo, and ensure that test requirements are met.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Since all the batches start with the same content, we can reuse the same
buf to fill them.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
A similar expectation as to the current test that flips do not stall
cursor updates.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Silly compiler emitting warnings that just cause people to break code
attempting to silence the compiler.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Aparently we never supported that mode of operation. Maybe in the future
we will, but for now just use the vblank wait to align ourselves with
the vblank.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
A common problem when trying to unify legacy and atomic is the breaking
of existing non-blocking, asynchronous userspace. The most trivial
example is a cursor that stalls for a pageflip.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
So that we can add an alternative implementation for the other arches.
This is basically what the kernel does.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
|
|
Saturate the CPUs with background RT threads to soak up any spare CPU
not taken by testing threads.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
igt_fixture and its byzantine requirements
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Just to compare handling of plane->mutexes
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Looking at the uncontended cases reveals a major contention cliff.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
|
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
|
