1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
|
/*
* (C) COPYRIGHT 2017 ARM Limited. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*
*/
#include <errno.h>
#include <stdbool.h>
#include <stdio.h>
#include <string.h>
#include "igt.h"
#include "igt_core.h"
#include "igt_fb.h"
#include "sw_sync.h"
IGT_TEST_DESCRIPTION(
"This test validates the expected behavior of the writeback connectors "
"feature by checking if the target device support writeback; it validates "
"bad and good combination, check color format, and check the output result "
"by using CRC."
);
static drmModePropertyBlobRes *get_writeback_formats_blob(igt_output_t *output)
{
drmModePropertyBlobRes *blob = NULL;
uint64_t blob_id;
int ret;
ret = kmstest_get_property(output->display->drm_fd,
output->config.connector->connector_id,
DRM_MODE_OBJECT_CONNECTOR,
igt_connector_prop_names[IGT_CONNECTOR_WRITEBACK_PIXEL_FORMATS],
NULL, &blob_id, NULL);
if (ret)
blob = drmModeGetPropertyBlob(output->display->drm_fd, blob_id);
igt_assert(blob);
return blob;
}
static bool check_writeback_config(igt_display_t *display, igt_output_t *output)
{
igt_fb_t input_fb, output_fb;
igt_plane_t *plane;
uint32_t writeback_format = DRM_FORMAT_XRGB8888;
uint64_t tiling = DRM_FORMAT_MOD_LINEAR;
int width, height, ret;
drmModeModeInfo override_mode = {
.clock = 25175,
.hdisplay = 640,
.hsync_start = 656,
.hsync_end = 752,
.htotal = 800,
.hskew = 0,
.vdisplay = 480,
.vsync_start = 490,
.vsync_end = 492,
.vtotal = 525,
.vscan = 0,
.vrefresh = 60,
.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
.name = {"640x480-60"},
};
igt_output_override_mode(output, &override_mode);
width = override_mode.hdisplay;
height = override_mode.vdisplay;
ret = igt_create_fb(display->drm_fd, width, height, DRM_FORMAT_XRGB8888, tiling, &input_fb);
igt_assert(ret >= 0);
ret = igt_create_fb(display->drm_fd, width, height, writeback_format, tiling, &output_fb);
igt_assert(ret >= 0);
plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_plane_set_fb(plane, &input_fb);
igt_output_set_writeback_fb(output, &output_fb);
ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
igt_plane_set_fb(plane, NULL);
igt_remove_fb(display->drm_fd, &input_fb);
igt_remove_fb(display->drm_fd, &output_fb);
return !ret;
}
static igt_output_t *kms_writeback_get_output(igt_display_t *display)
{
int i;
for (i = 0; i < display->n_outputs; i++) {
igt_output_t *output = &display->outputs[i];
int j;
if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)
continue;
for (j = 0; j < igt_display_get_n_pipes(display); j++) {
igt_output_set_pipe(output, j);
if (check_writeback_config(display, output)) {
igt_debug("Using connector %u:%s on pipe %d\n",
output->config.connector->connector_id,
output->name, j);
return output;
}
}
igt_debug("We found %u:%s, but this test will not be able to use it.\n",
output->config.connector->connector_id, output->name);
/* Restore any connectors we don't use, so we don't trip on them later */
kmstest_force_connector(display->drm_fd, output->config.connector, FORCE_CONNECTOR_UNSPECIFIED);
}
return NULL;
}
static void check_writeback_fb_id(igt_output_t *output)
{
uint64_t check_fb_id;
check_fb_id = igt_output_get_prop(output, IGT_CONNECTOR_WRITEBACK_FB_ID);
igt_assert(check_fb_id == 0);
}
static int do_writeback_test(igt_output_t *output, uint32_t fb_id,
int32_t *out_fence_ptr, bool ptr_valid)
{
int ret;
igt_display_t *display = output->display;
struct kmstest_connector_config *config = &output->config;
igt_output_set_prop_value(output, IGT_CONNECTOR_CRTC_ID, config->crtc->crtc_id);
igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_FB_ID, fb_id);
igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR, to_user_pointer(out_fence_ptr));
if (ptr_valid)
*out_fence_ptr = 0;
ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
if (ptr_valid)
igt_assert(*out_fence_ptr == -1);
/* WRITEBACK_FB_ID must always read as zero */
check_writeback_fb_id(output);
return ret;
}
static void test_invalid_parameters(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t *invalid_fb)
{
int i, ret;
int32_t out_fence;
struct {
uint32_t fb_id;
bool ptr_valid;
int32_t *out_fence_ptr;
} invalid_tests[] = {
{
/* No output buffer, but the WRITEBACK_OUT_FENCE_PTR set. */
.fb_id = 0,
.ptr_valid = true,
.out_fence_ptr = &out_fence,
},
{
/* Invalid output buffer. */
.fb_id = invalid_fb->fb_id,
.ptr_valid = true,
.out_fence_ptr = &out_fence,
},
{
/* Invalid WRITEBACK_OUT_FENCE_PTR. */
.fb_id = valid_fb->fb_id,
.ptr_valid = false,
.out_fence_ptr = (int32_t *)0x8,
},
};
for (i = 0; i < ARRAY_SIZE(invalid_tests); i++) {
ret = do_writeback_test(output, invalid_tests[i].fb_id,
invalid_tests[i].out_fence_ptr,
invalid_tests[i].ptr_valid);
igt_assert(ret != 0);
}
}
static void writeback_fb_id(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t *invalid_fb)
{
int ret;
/* Invalid object for WRITEBACK_FB_ID */
ret = do_writeback_test(output, output->id, NULL, false);
igt_assert(ret == -EINVAL);
/* Zero WRITEBACK_FB_ID */
ret = do_writeback_test(output, 0, NULL, false);
igt_assert(ret == 0);
/* Valid output buffer */
ret = do_writeback_test(output, valid_fb->fb_id, NULL, false);
igt_assert(ret == 0);
}
static void fill_fb(igt_fb_t *fb, uint32_t pixel)
{
void *ptr;
igt_assert(fb->drm_format == DRM_FORMAT_XRGB8888);
ptr = igt_fb_map_buffer(fb->fd, fb);
igt_assert(ptr);
memset(ptr, pixel, fb->strides[0] * fb->height);
igt_fb_unmap_buffer(fb, ptr);
}
static void get_and_wait_out_fence(igt_output_t *output)
{
int ret;
igt_assert(output->writeback_out_fence_fd >= 0);
ret = sync_fence_wait(output->writeback_out_fence_fd, 1000);
igt_assert_f(ret == 0, "sync_fence_wait failed: %s\n", strerror(-ret));
close(output->writeback_out_fence_fd);
output->writeback_out_fence_fd = -1;
}
static void writeback_sequence(igt_output_t *output, igt_plane_t *plane,
igt_fb_t *in_fb, igt_fb_t *out_fbs[], int n_commits)
{
int i = 0;
uint32_t in_fb_colors[2] = { 0xffff0000, 0xff00ff00 };
uint32_t clear_color = 0xffffffff;
igt_crc_t cleared_crc, out_expected;
for (i = 0; i < n_commits; i++) {
/* Change the input color each time */
fill_fb(in_fb, in_fb_colors[i % 2]);
if (out_fbs[i]) {
igt_crc_t out_before;
/* Get the expected CRC */
igt_fb_get_fnv1a_crc(in_fb, &out_expected);
fill_fb(out_fbs[i], clear_color);
if (i == 0)
igt_fb_get_fnv1a_crc(out_fbs[i], &cleared_crc);
igt_fb_get_fnv1a_crc(out_fbs[i], &out_before);
igt_assert_crc_equal(&cleared_crc, &out_before);
}
/* Commit */
igt_plane_set_fb(plane, in_fb);
igt_output_set_writeback_fb(output, out_fbs[i]);
igt_display_commit_atomic(output->display,
DRM_MODE_ATOMIC_ALLOW_MODESET,
NULL);
if (out_fbs[i])
get_and_wait_out_fence(output);
/* Make sure the old output buffer is untouched */
if (i > 0 && out_fbs[i - 1] && out_fbs[i] != out_fbs[i - 1]) {
igt_crc_t out_prev;
igt_fb_get_fnv1a_crc(out_fbs[i - 1], &out_prev);
igt_assert_crc_equal(&cleared_crc, &out_prev);
}
/* Make sure this output buffer is written */
if (out_fbs[i]) {
igt_crc_t out_after;
igt_fb_get_fnv1a_crc(out_fbs[i], &out_after);
igt_assert_crc_equal(&out_expected, &out_after);
/* And clear it, for the next time */
fill_fb(out_fbs[i], clear_color);
}
}
}
static void writeback_check_output(igt_output_t *output, igt_plane_t *plane,
igt_fb_t *input_fb, igt_fb_t *output_fb)
{
igt_fb_t *out_fbs[2] = { 0 };
igt_fb_t second_out_fb;
unsigned int fb_id;
/* One commit, with a writeback. */
writeback_sequence(output, plane, input_fb, &output_fb, 1);
/* Two commits, the second with no writeback */
out_fbs[0] = output_fb;
writeback_sequence(output, plane, input_fb, out_fbs, 2);
/* Two commits, both with writeback */
out_fbs[1] = output_fb;
writeback_sequence(output, plane, input_fb, out_fbs, 2);
fb_id = igt_create_fb(output_fb->fd, output_fb->width, output_fb->height,
DRM_FORMAT_XRGB8888,
igt_fb_mod_to_tiling(0),
&second_out_fb);
igt_require(fb_id > 0);
/* Two commits, with different writeback buffers */
out_fbs[1] = &second_out_fb;
writeback_sequence(output, plane, input_fb, out_fbs, 2);
igt_remove_fb(output_fb->fd, &second_out_fb);
}
igt_main
{
igt_display_t display;
igt_output_t *output;
igt_plane_t *plane;
igt_fb_t input_fb;
drmModeModeInfo mode;
unsigned int fb_id;
memset(&display, 0, sizeof(display));
igt_fixture {
display.drm_fd = drm_open_driver_master(DRIVER_ANY);
igt_display_require(&display, display.drm_fd);
kmstest_set_vt_graphics_mode();
igt_display_require(&display, display.drm_fd);
igt_require(display.is_atomic);
output = kms_writeback_get_output(&display);
igt_require(output);
if (output->use_override_mode)
memcpy(&mode, &output->override_mode, sizeof(mode));
else
memcpy(&mode, &output->config.default_mode, sizeof(mode));
plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
igt_assert(plane);
fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
mode.vdisplay,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR,
&input_fb);
igt_assert(fb_id >= 0);
igt_plane_set_fb(plane, &input_fb);
}
igt_describe("Check the writeback format");
igt_subtest("writeback-pixel-formats") {
drmModePropertyBlobRes *formats_blob = get_writeback_formats_blob(output);
const char *valid_chars = "0123456 ABCGNRUVXY";
unsigned int i;
char *c;
/*
* We don't have a comprehensive list of formats, so just check
* that the blob length is sensible and that it doesn't contain
* any outlandish characters
*/
igt_assert(!(formats_blob->length % 4));
c = formats_blob->data;
for (i = 0; i < formats_blob->length; i++)
igt_assert_f(strchr(valid_chars, c[i]),
"Unexpected character %c\n", c[i]);
drmModeFreePropertyBlob(formats_blob);
}
igt_describe("Writeback has a couple of parameters linked together"
"(output framebuffer and fence); this test goes through"
"the combination of possible bad options");
igt_subtest("writeback-invalid-parameters") {
igt_fb_t invalid_output_fb;
fb_id = igt_create_fb(display.drm_fd, mode.hdisplay / 2,
mode.vdisplay / 2,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR,
&invalid_output_fb);
igt_require(fb_id > 0);
test_invalid_parameters(output, &input_fb, &invalid_output_fb);
igt_remove_fb(display.drm_fd, &invalid_output_fb);
}
igt_describe("Validate WRITEBACK_FB_ID with valid and invalid options");
igt_subtest("writeback-fb-id") {
igt_fb_t output_fb;
fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888,
DRM_FORMAT_MOD_LINEAR,
&output_fb);
igt_require(fb_id > 0);
writeback_fb_id(output, &input_fb, &output_fb);
igt_remove_fb(display.drm_fd, &output_fb);
}
igt_describe("Check writeback output with CRC validation");
igt_subtest("writeback-check-output") {
igt_fb_t output_fb;
fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
DRM_FORMAT_XRGB8888,
igt_fb_mod_to_tiling(0),
&output_fb);
igt_require(fb_id > 0);
writeback_check_output(output, plane, &input_fb, &output_fb);
igt_remove_fb(display.drm_fd, &output_fb);
}
igt_fixture {
igt_remove_fb(display.drm_fd, &input_fb);
igt_display_fini(&display);
}
}
|