diff options
author | Jubin John <jubin.john@intel.com> | 2016-08-31 07:24:27 -0700 |
---|---|---|
committer | Doug Ledford <dledford@redhat.com> | 2016-09-02 14:26:55 -0400 |
commit | af53493916693343955930556aaa83f875b8436a (patch) | |
tree | 80171cbc25a88cad30ca48c3d9cfb371e2628e56 /COPYING | |
parent | 3e6c3b0fd5d071ed17bf91586aae35a6cfb8cdb3 (diff) |
IB/hfi1: Fix AHG KDETH Intr shift
In the set_txreq_header_ahg(), The KDETH Intr bit is obtained from the
header in the user sdma request using a KDETH_GET shift and mask macro.
This value is then futher right shifted by 16 causing us to lose the
value i.e it is shifted to zero, leading to the following
smatch warning:
drivers/infiniband/hw/hfi1/user_sdma.c:1482 set_txreq_header_ahg()
warn: mask and shift to zero
The Intr bit should be left shifted into its correct position in the
KDETH header before the AHG update.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Reviewed-by: Harish Chegondi <harish.chegondi@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions