summaryrefslogtreecommitdiff
path: root/arch/arm64/kernel
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2016-03-04 12:54:05 +0000
committerCatalin Marinas <catalin.marinas@arm.com>2016-03-04 14:12:46 +0000
commit1cc6ed90dd7313055dec0174e2cda745ebadd6b0 (patch)
tree4b517d6848f377ee261558d3cbd9a877325308c7 /arch/arm64/kernel
parent57efac2f7108e3255d0dfe512290c9896f4ed55f (diff)
arm64: make mrs_s prefixing implicit in read_cpuid
Commit 0f54b14e76f5302a ("arm64: cpufeature: Change read_cpuid() to use sysreg's mrs_s macro") changed read_cpuid to require a SYS_ prefix on register names, to allow manual assembly of registers unknown by the toolchain, using tables in sysreg.h. This interacts poorly with commit 42b55734030c1f72 ("efi/arm64: Check for h/w support before booting a >4 KB granular kernel"), which is curretly queued via the tip tree, and uses read_cpuid without a SYS_ prefix. Due to this, a build of next-20160304 fails if EFI and 64K pages are selected. To avoid this issue when trees are merged, move the required SYS_ prefixing into read_cpuid, and revert all of the updated callsites to pass plain register names. This effectively reverts the bulk of commit 0f54b14e76f5302a. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: James Morse <james.morse@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'arch/arm64/kernel')
-rw-r--r--arch/arm64/kernel/cpufeature.c60
-rw-r--r--arch/arm64/kernel/cpuinfo.c56
2 files changed, 58 insertions, 58 deletions
diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index 3c9d70883276..392c67eb9fa6 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -855,36 +855,36 @@ static inline void set_sys_caps_initialised(void)
static u64 __raw_read_system_reg(u32 sys_id)
{
switch (sys_id) {
- case SYS_ID_PFR0_EL1: return read_cpuid(SYS_ID_PFR0_EL1);
- case SYS_ID_PFR1_EL1: return read_cpuid(SYS_ID_PFR1_EL1);
- case SYS_ID_DFR0_EL1: return read_cpuid(SYS_ID_DFR0_EL1);
- case SYS_ID_MMFR0_EL1: return read_cpuid(SYS_ID_MMFR0_EL1);
- case SYS_ID_MMFR1_EL1: return read_cpuid(SYS_ID_MMFR1_EL1);
- case SYS_ID_MMFR2_EL1: return read_cpuid(SYS_ID_MMFR2_EL1);
- case SYS_ID_MMFR3_EL1: return read_cpuid(SYS_ID_MMFR3_EL1);
- case SYS_ID_ISAR0_EL1: return read_cpuid(SYS_ID_ISAR0_EL1);
- case SYS_ID_ISAR1_EL1: return read_cpuid(SYS_ID_ISAR1_EL1);
- case SYS_ID_ISAR2_EL1: return read_cpuid(SYS_ID_ISAR2_EL1);
- case SYS_ID_ISAR3_EL1: return read_cpuid(SYS_ID_ISAR3_EL1);
- case SYS_ID_ISAR4_EL1: return read_cpuid(SYS_ID_ISAR4_EL1);
- case SYS_ID_ISAR5_EL1: return read_cpuid(SYS_ID_ISAR4_EL1);
- case SYS_MVFR0_EL1: return read_cpuid(SYS_MVFR0_EL1);
- case SYS_MVFR1_EL1: return read_cpuid(SYS_MVFR1_EL1);
- case SYS_MVFR2_EL1: return read_cpuid(SYS_MVFR2_EL1);
-
- case SYS_ID_AA64PFR0_EL1: return read_cpuid(SYS_ID_AA64PFR0_EL1);
- case SYS_ID_AA64PFR1_EL1: return read_cpuid(SYS_ID_AA64PFR0_EL1);
- case SYS_ID_AA64DFR0_EL1: return read_cpuid(SYS_ID_AA64DFR0_EL1);
- case SYS_ID_AA64DFR1_EL1: return read_cpuid(SYS_ID_AA64DFR0_EL1);
- case SYS_ID_AA64MMFR0_EL1: return read_cpuid(SYS_ID_AA64MMFR0_EL1);
- case SYS_ID_AA64MMFR1_EL1: return read_cpuid(SYS_ID_AA64MMFR1_EL1);
- case SYS_ID_AA64MMFR2_EL1: return read_cpuid(SYS_ID_AA64MMFR2_EL1);
- case SYS_ID_AA64ISAR0_EL1: return read_cpuid(SYS_ID_AA64ISAR0_EL1);
- case SYS_ID_AA64ISAR1_EL1: return read_cpuid(SYS_ID_AA64ISAR1_EL1);
-
- case SYS_CNTFRQ_EL0: return read_cpuid(SYS_CNTFRQ_EL0);
- case SYS_CTR_EL0: return read_cpuid(SYS_CTR_EL0);
- case SYS_DCZID_EL0: return read_cpuid(SYS_DCZID_EL0);
+ case SYS_ID_PFR0_EL1: return read_cpuid(ID_PFR0_EL1);
+ case SYS_ID_PFR1_EL1: return read_cpuid(ID_PFR1_EL1);
+ case SYS_ID_DFR0_EL1: return read_cpuid(ID_DFR0_EL1);
+ case SYS_ID_MMFR0_EL1: return read_cpuid(ID_MMFR0_EL1);
+ case SYS_ID_MMFR1_EL1: return read_cpuid(ID_MMFR1_EL1);
+ case SYS_ID_MMFR2_EL1: return read_cpuid(ID_MMFR2_EL1);
+ case SYS_ID_MMFR3_EL1: return read_cpuid(ID_MMFR3_EL1);
+ case SYS_ID_ISAR0_EL1: return read_cpuid(ID_ISAR0_EL1);
+ case SYS_ID_ISAR1_EL1: return read_cpuid(ID_ISAR1_EL1);
+ case SYS_ID_ISAR2_EL1: return read_cpuid(ID_ISAR2_EL1);
+ case SYS_ID_ISAR3_EL1: return read_cpuid(ID_ISAR3_EL1);
+ case SYS_ID_ISAR4_EL1: return read_cpuid(ID_ISAR4_EL1);
+ case SYS_ID_ISAR5_EL1: return read_cpuid(ID_ISAR4_EL1);
+ case SYS_MVFR0_EL1: return read_cpuid(MVFR0_EL1);
+ case SYS_MVFR1_EL1: return read_cpuid(MVFR1_EL1);
+ case SYS_MVFR2_EL1: return read_cpuid(MVFR2_EL1);
+
+ case SYS_ID_AA64PFR0_EL1: return read_cpuid(ID_AA64PFR0_EL1);
+ case SYS_ID_AA64PFR1_EL1: return read_cpuid(ID_AA64PFR0_EL1);
+ case SYS_ID_AA64DFR0_EL1: return read_cpuid(ID_AA64DFR0_EL1);
+ case SYS_ID_AA64DFR1_EL1: return read_cpuid(ID_AA64DFR0_EL1);
+ case SYS_ID_AA64MMFR0_EL1: return read_cpuid(ID_AA64MMFR0_EL1);
+ case SYS_ID_AA64MMFR1_EL1: return read_cpuid(ID_AA64MMFR1_EL1);
+ case SYS_ID_AA64MMFR2_EL1: return read_cpuid(ID_AA64MMFR2_EL1);
+ case SYS_ID_AA64ISAR0_EL1: return read_cpuid(ID_AA64ISAR0_EL1);
+ case SYS_ID_AA64ISAR1_EL1: return read_cpuid(ID_AA64ISAR1_EL1);
+
+ case SYS_CNTFRQ_EL0: return read_cpuid(CNTFRQ_EL0);
+ case SYS_CTR_EL0: return read_cpuid(CTR_EL0);
+ case SYS_DCZID_EL0: return read_cpuid(DCZID_EL0);
default:
BUG();
return 0;
diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index 00bdfa3f4532..84c8684431c7 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -203,36 +203,36 @@ static void __cpuinfo_store_cpu(struct cpuinfo_arm64 *info)
{
info->reg_cntfrq = arch_timer_get_cntfrq();
info->reg_ctr = read_cpuid_cachetype();
- info->reg_dczid = read_cpuid(SYS_DCZID_EL0);
+ info->reg_dczid = read_cpuid(DCZID_EL0);
info->reg_midr = read_cpuid_id();
- info->reg_id_aa64dfr0 = read_cpuid(SYS_ID_AA64DFR0_EL1);
- info->reg_id_aa64dfr1 = read_cpuid(SYS_ID_AA64DFR1_EL1);
- info->reg_id_aa64isar0 = read_cpuid(SYS_ID_AA64ISAR0_EL1);
- info->reg_id_aa64isar1 = read_cpuid(SYS_ID_AA64ISAR1_EL1);
- info->reg_id_aa64mmfr0 = read_cpuid(SYS_ID_AA64MMFR0_EL1);
- info->reg_id_aa64mmfr1 = read_cpuid(SYS_ID_AA64MMFR1_EL1);
- info->reg_id_aa64mmfr2 = read_cpuid(SYS_ID_AA64MMFR2_EL1);
- info->reg_id_aa64pfr0 = read_cpuid(SYS_ID_AA64PFR0_EL1);
- info->reg_id_aa64pfr1 = read_cpuid(SYS_ID_AA64PFR1_EL1);
-
- info->reg_id_dfr0 = read_cpuid(SYS_ID_DFR0_EL1);
- info->reg_id_isar0 = read_cpuid(SYS_ID_ISAR0_EL1);
- info->reg_id_isar1 = read_cpuid(SYS_ID_ISAR1_EL1);
- info->reg_id_isar2 = read_cpuid(SYS_ID_ISAR2_EL1);
- info->reg_id_isar3 = read_cpuid(SYS_ID_ISAR3_EL1);
- info->reg_id_isar4 = read_cpuid(SYS_ID_ISAR4_EL1);
- info->reg_id_isar5 = read_cpuid(SYS_ID_ISAR5_EL1);
- info->reg_id_mmfr0 = read_cpuid(SYS_ID_MMFR0_EL1);
- info->reg_id_mmfr1 = read_cpuid(SYS_ID_MMFR1_EL1);
- info->reg_id_mmfr2 = read_cpuid(SYS_ID_MMFR2_EL1);
- info->reg_id_mmfr3 = read_cpuid(SYS_ID_MMFR3_EL1);
- info->reg_id_pfr0 = read_cpuid(SYS_ID_PFR0_EL1);
- info->reg_id_pfr1 = read_cpuid(SYS_ID_PFR1_EL1);
-
- info->reg_mvfr0 = read_cpuid(SYS_MVFR0_EL1);
- info->reg_mvfr1 = read_cpuid(SYS_MVFR1_EL1);
- info->reg_mvfr2 = read_cpuid(SYS_MVFR2_EL1);
+ info->reg_id_aa64dfr0 = read_cpuid(ID_AA64DFR0_EL1);
+ info->reg_id_aa64dfr1 = read_cpuid(ID_AA64DFR1_EL1);
+ info->reg_id_aa64isar0 = read_cpuid(ID_AA64ISAR0_EL1);
+ info->reg_id_aa64isar1 = read_cpuid(ID_AA64ISAR1_EL1);
+ info->reg_id_aa64mmfr0 = read_cpuid(ID_AA64MMFR0_EL1);
+ info->reg_id_aa64mmfr1 = read_cpuid(ID_AA64MMFR1_EL1);
+ info->reg_id_aa64mmfr2 = read_cpuid(ID_AA64MMFR2_EL1);
+ info->reg_id_aa64pfr0 = read_cpuid(ID_AA64PFR0_EL1);
+ info->reg_id_aa64pfr1 = read_cpuid(ID_AA64PFR1_EL1);
+
+ info->reg_id_dfr0 = read_cpuid(ID_DFR0_EL1);
+ info->reg_id_isar0 = read_cpuid(ID_ISAR0_EL1);
+ info->reg_id_isar1 = read_cpuid(ID_ISAR1_EL1);
+ info->reg_id_isar2 = read_cpuid(ID_ISAR2_EL1);
+ info->reg_id_isar3 = read_cpuid(ID_ISAR3_EL1);
+ info->reg_id_isar4 = read_cpuid(ID_ISAR4_EL1);
+ info->reg_id_isar5 = read_cpuid(ID_ISAR5_EL1);
+ info->reg_id_mmfr0 = read_cpuid(ID_MMFR0_EL1);
+ info->reg_id_mmfr1 = read_cpuid(ID_MMFR1_EL1);
+ info->reg_id_mmfr2 = read_cpuid(ID_MMFR2_EL1);
+ info->reg_id_mmfr3 = read_cpuid(ID_MMFR3_EL1);
+ info->reg_id_pfr0 = read_cpuid(ID_PFR0_EL1);
+ info->reg_id_pfr1 = read_cpuid(ID_PFR1_EL1);
+
+ info->reg_mvfr0 = read_cpuid(MVFR0_EL1);
+ info->reg_mvfr1 = read_cpuid(MVFR1_EL1);
+ info->reg_mvfr2 = read_cpuid(MVFR2_EL1);
cpuinfo_detect_icache_policy(info);