diff options
| author | Petr Machata <petrm@mellanox.com> | 2018-03-22 19:53:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-23 12:54:34 -0400 |
| commit | f6cc9c054e77b9a28d4594bcc201697edb21dfd2 (patch) | |
| tree | bbe5149057467d5c4555189466cb56b5f45b38e3 /drivers/fpga/fpga-bridge.c | |
| parent | f36b7534b83357cf52e747905de6d65b4f7c2512 (diff) | |
ip_tunnel: Emit events for post-register MTU changes
For tunnels created with IFLA_MTU, MTU of the netdevice is set by
rtnl_create_link() (called from rtnl_newlink()) before the device is
registered. However without IFLA_MTU that's not done.
rtnl_newlink() proceeds by calling struct rtnl_link_ops.newlink, which
via ip_tunnel_newlink() calls register_netdevice(), and that emits
NETDEV_REGISTER. Thus any listeners that inspect the netdevice get the
MTU of 0.
After ip_tunnel_newlink() corrects the MTU after registering the
netdevice, but since there's no event, the listeners don't get to know
about the MTU until something else happens--such as a NETDEV_UP event.
That's not ideal.
So instead of setting the MTU directly, go through dev_set_mtu(), which
takes care of distributing the necessary NETDEV_PRECHANGEMTU and
NETDEV_CHANGEMTU events.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/fpga/fpga-bridge.c')
0 files changed, 0 insertions, 0 deletions