diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2017-04-04 13:05:31 +0100 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2017-04-26 16:27:58 +0300 |
commit | d445aaaac0879a4c4400bf59f20465ba3e8445f1 (patch) | |
tree | 6e53e03eeb20182f7d9cbb307ccc992e5146d3ee /drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | |
parent | 1676a2b35cd5a548da17d1106fb0d4d238c0d191 (diff) |
drm/i915: Apply a cond_resched() to the saturated signaler
If the engine is continually completing nops, we can saturate the
signaler and keep it working indefinitely. This angers the NMI watchdog!
A good example is to disable semaphores on snb and run igt/gem_exec_nop -
the parallel, multi-engine workloads are more than sufficient to hog the
CPU, preventing the system from even processing ICMP echo replies.
v2: Tvrtko dug into cond_resched() on x86 and found that it only
depended upon preempt_count and not tif_need_resched() - which means
that we would always call schedule() at that point.
Fixes: c81d46138da6 ("drm/i915: Convert trace-irq to the breadcrumb waiter")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170404120531.10737-1-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
(cherry picked from commit a7980a640cbd339aa80f406d1786a275a2c320bc)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c')
0 files changed, 0 insertions, 0 deletions