diff options
author | Chris Packham <chris.packham@alliedtelesis.co.nz> | 2021-12-07 17:21:44 +1300 |
---|---|---|
committer | Wolfram Sang <wsa@kernel.org> | 2021-12-10 22:27:30 +0100 |
commit | a74c313aca266fab0d1d1a72becbb8b7b5286b6e (patch) | |
tree | 3c41f5089c73b7d05337d8d5685aef0137c66024 /drivers/hwmon/pwm-fan.c | |
parent | b503de239f62eca898cfb7e820d9a35499137d22 (diff) |
i2c: mpc: Use atomic read and fix break condition
Maxime points out that the polling code in mpc_i2c_isr should use the
_atomic API because it is called in an irq context and that the
behaviour of the MCF bit is that it is 1 when the byte transfer is
complete. All of this means the original code was effectively a
udelay(100).
Fix this by using readb_poll_timeout_atomic() and removing the negation
of the break condition.
Fixes: 4a8ac5e45cda ("i2c: mpc: Poll for MCF")
Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Tested-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/hwmon/pwm-fan.c')
0 files changed, 0 insertions, 0 deletions