summaryrefslogtreecommitdiff
path: root/drivers/mcb
diff options
context:
space:
mode:
authorIdo Schimmel <idosch@nvidia.com>2021-01-28 16:48:20 +0200
committerJakub Kicinski <kuba@kernel.org>2021-01-28 13:09:01 -0800
commitb6f6881aaf2344bf35a4221810737abe5fd210af (patch)
tree36e1990eeab1372cfcdeb9a3061c56cb0f482484 /drivers/mcb
parent11df27f7fdf02cc2bb354358ad482e1fdd690589 (diff)
mlxsw: spectrum_span: Do not overwrite policer configuration
The purpose of the delayed work in the SPAN module is to potentially update the destination port and various encapsulation parameters of SPAN agents that point to a VLAN device or a GRE tap. The destination port can change following the insertion of a new route, for example. SPAN agents that point to a physical port or the CPU port are static and never change throughout the lifetime of the SPAN agent. Therefore, skip over them in the delayed work. This fixes an issue where the delayed work overwrites the policer that was set on a SPAN agent pointing to the CPU. Modifying the delayed work to inherit the original policer configuration is error-prone, as the same will be needed for any new parameter. Fixes: 4039504e6a0c ("mlxsw: spectrum_span: Allow setting policer on a SPAN agent") Reviewed-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/mcb')
0 files changed, 0 insertions, 0 deletions