summaryrefslogtreecommitdiff
path: root/drivers/soc
diff options
context:
space:
mode:
authorWan Jiabing <wanjiabing@vivo.com>2021-10-14 04:30:17 -0400
committerBjorn Andersson <bjorn.andersson@linaro.org>2021-10-24 12:12:57 -0500
commit72f1aa6205d84337b90b065f602a8fe190821781 (patch)
tree05452c0e0a89091f9ba1f5877ff7de913af10ef2 /drivers/soc
parent62563bd99c7d7be269982b88173ad8938420d648 (diff)
soc: qcom: apr: Add of_node_put() before return
Fix following coccicheck warning: ./drivers/soc/qcom/apr.c:485:1-23: WARNING: Function for_each_child_of_node should have of_node_put() before return Early exits from for_each_child_of_node should decrement the node reference counter. Fixes: 834735662602 ("soc: qcom: apr: Add avs/audio tracking functionality") Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20211014083017.19714-1-wanjiabing@vivo.com
Diffstat (limited to 'drivers/soc')
-rw-r--r--drivers/soc/qcom/apr.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
index 8a9bfbcd4bb9..82ca12c9328a 100644
--- a/drivers/soc/qcom/apr.c
+++ b/drivers/soc/qcom/apr.c
@@ -492,12 +492,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
1, &service_path);
if (ret < 0) {
dev_err(dev, "pdr service path missing: %d\n", ret);
+ of_node_put(node);
return ret;
}
pds = pdr_add_lookup(apr->pdr, service_name, service_path);
if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
+ of_node_put(node);
return PTR_ERR(pds);
}
}