summaryrefslogtreecommitdiff
path: root/drivers/usb/cdns3/cdns3-imx.c
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <krzk@kernel.org>2020-07-24 09:40:30 +0200
committerKrzysztof Kozlowski <krzk@kernel.org>2020-08-17 20:43:38 +0200
commit1724f1b6963a412d42696dd0d3c172fe983d1353 (patch)
treec2751d5b946548ddece8f4d1b8ac4433502edbb7 /drivers/usb/cdns3/cdns3-imx.c
parentd25112aa34d007deaef3f2b373ab98ab1a7fc92d (diff)
memory: omap-gpmc: remove GPMC_SET_ONE_CD_MAX macro for safety
The GPMC_SET_ONE_CD_MAX macro uses return statement and variable 'cs' coming from called scope. This is not a good practice. Also checkpatch complained: WARNING: Macros with flow control statements should be avoided ERROR: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Since GPMC_SET_ONE_CD_MAX macro just calls one function, it can be open coded. The difference with original code is that function will exit on error not after every register set, but after a group of sets. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200724074038.5597-22-krzk@kernel.org
Diffstat (limited to 'drivers/usb/cdns3/cdns3-imx.c')
0 files changed, 0 insertions, 0 deletions