diff options
| author | Almog Khaikin <almogkh@gmail.com> | 2022-04-26 19:34:03 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-04-30 08:39:54 -0600 |
| commit | f2e030dd7aaea5a937a2547dc980fab418fbc5e7 (patch) | |
| tree | 23c92eed18bed2eb641ec38b14c87074faf4c599 /fs/io_uring.c | |
| parent | ef060ea9e4fd3b763e7060a3af0a258d2d5d7c0d (diff) | |
io_uring: replace smp_mb() with smp_mb__after_atomic() in io_sq_thread()
The IORING_SQ_NEED_WAKEUP flag is now set using atomic_or() which
implies a full barrier on some architectures but it is not required to
do so. Use the more appropriate smp_mb__after_atomic() which avoids the
extra barrier on those architectures.
Signed-off-by: Almog Khaikin <almogkh@gmail.com>
Link: https://lore.kernel.org/r/20220426163403.112692-1-almogkh@gmail.com
Fixes: 8018823e6987 ("io_uring: serialize ctx->rings->sq_flags with atomic_or/and")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 72cb2d50125c..1e7466079af7 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -8229,7 +8229,7 @@ static int io_sq_thread(void *data) * Ensure the store of the wakeup flag is not * reordered with the load of the SQ tail */ - smp_mb(); + smp_mb__after_atomic(); if (io_sqring_entries(ctx)) { needs_sched = false; |