diff options
author | NeilBrown <neilb@suse.de> | 2014-09-16 12:14:14 +1000 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2014-09-22 11:26:01 +1000 |
commit | 34e97f170149bfa14979581c4c748bc9b4b79d5b (patch) | |
tree | bc1ba06965b5330491a2aef8a23f86cd1e93f6f2 /fs/xfs/xfs_super.h | |
parent | c2fd4c94deedb89ac1746c4a53219be499372c06 (diff) |
md/raid1: count resync requests in nr_pending.
Both normal IO and resync IO can be retried with reschedule_retry()
and so be counted into ->nr_queued, but only normal IO gets counted in
->nr_pending.
Before the recent improvement to RAID1 resync there could only
possibly have been one or the other on the queue. When handling a
read failure it could only be normal IO. So when handle_read_error()
called freeze_array() the fact that freeze_array only compares
->nr_queued against ->nr_pending was safe.
But now that these two types can interleave, we can have both normal
and resync IO requests queued, so we need to count them both in
nr_pending.
This error can lead to freeze_array() hanging if there is a read
error, so it is suitable for -stable.
Fixes: 79ef3a8aa1cb1523cc231c9a90a278333c21f761
cc: stable@vger.kernel.org (v3.13+)
Reported-by: Brassow Jonathan <jbrassow@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'fs/xfs/xfs_super.h')
0 files changed, 0 insertions, 0 deletions