diff options
author | Lukas Hannen <lukas.hannen@opensource.tttech-industrial.com> | 2021-08-25 10:12:43 +0000 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2021-09-08 17:44:26 +0200 |
commit | 39ff83f2f6cc5cc1458dfcea9697f96338210beb (patch) | |
tree | 8756a234c0185493b29496080d8a682fdc8dba8d /lib/mpi/mpicoder.c | |
parent | 8596e589b787732c8346f0482919e83cc9362db1 (diff) |
time: Handle negative seconds correctly in timespec64_to_ns()
timespec64_ns() prevents multiplication overflows by comparing the seconds
value of the timespec to KTIME_SEC_MAX. If the value is greater or equal it
returns KTIME_MAX.
But that check casts the signed seconds value to unsigned which makes the
comparision true for all negative values and therefore return wrongly
KTIME_MAX.
Negative second values are perfectly valid and required in some places,
e.g. ptp_clock_adjtime().
Remove the cast and add a check for the negative boundary which is required
to prevent undefined behaviour due to multiplication underflow.
Fixes: cb47755725da ("time: Prevent undefined behaviour in timespec64_to_ns()")'
Signed-off-by: Lukas Hannen <lukas.hannen@opensource.tttech-industrial.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/AM6PR01MB541637BD6F336B8FFB72AF80EEC69@AM6PR01MB5416.eurprd01.prod.exchangelabs.com
Diffstat (limited to 'lib/mpi/mpicoder.c')
0 files changed, 0 insertions, 0 deletions