diff options
author | René van Dorst <opensource@vdorst.com> | 2020-03-19 14:47:56 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-03-19 21:10:49 -0700 |
commit | 22259471b51925353bd7b16f864c79fdd76e425e (patch) | |
tree | 5f2b7b65ed8fc254f25c08844892d798d9d25d0e /net/ipv4/tcp_output.c | |
parent | 3ac9eb4210a95cf9b374f1d48ce99d87d79d2510 (diff) |
net: dsa: mt7530: Change the LINK bit to reflect the link status
Andrew reported:
After a number of network port link up/down changes, sometimes the switch
port gets stuck in a state where it thinks it is still transmitting packets
but the cpu port is not actually transmitting anymore. In this state you
will see a message on the console
"mtk_soc_eth 1e100000.ethernet eth0: transmit timed out" and the Tx counter
in ifconfig will be incrementing on virtual port, but not incrementing on
cpu port.
The issue is that MAC TX/RX status has no impact on the link status or
queue manager of the switch. So the queue manager just queues up packets
of a disabled port and sends out pause frames when the queue is full.
Change the LINK bit to reflect the link status.
Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch")
Reported-by: Andrew Smith <andrew.smith@digi.com>
Signed-off-by: René van Dorst <opensource@vdorst.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
0 files changed, 0 insertions, 0 deletions