diff options
| author | Leon Romanovsky <leonro@nvidia.com> | 2021-10-21 17:16:13 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-10-22 16:15:41 -0700 |
| commit | 99ad92eff76491331a90d839dd6b7225cf8dd53e (patch) | |
| tree | dfef3fe45c3caad73c18739f6ef66b24d54ddfc8 /net | |
| parent | 61e18ce7348bfefb5688a8bcd4b4d6b37c0f9b2a (diff) | |
devlink: Delete obsolete parameters publish API
The change of devlink_register() to be last devlink command together
with delayed notification logic made the publish API to be obsolete.
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/devlink.c | 57 |
1 files changed, 8 insertions, 49 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index 3464854015a2..e9802421ed50 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -4600,8 +4600,6 @@ static int devlink_nl_param_fill(struct sk_buff *msg, struct devlink *devlink, return -EOPNOTSUPP; param_value[i] = param_item->driverinit_value; } else { - if (!param_item->published) - continue; ctx.cmode = i; err = devlink_param_get(devlink, param, &ctx); if (err) @@ -9076,6 +9074,7 @@ static void devlink_notify_register(struct devlink *devlink) { struct devlink_trap_policer_item *policer_item; struct devlink_trap_group_item *group_item; + struct devlink_param_item *param_item; struct devlink_trap_item *trap_item; struct devlink_port *devlink_port; struct devlink_rate *rate_node; @@ -9102,19 +9101,24 @@ static void devlink_notify_register(struct devlink *devlink) list_for_each_entry(region, &devlink->region_list, list) devlink_nl_region_notify(region, NULL, DEVLINK_CMD_REGION_NEW); - devlink_params_publish(devlink); + list_for_each_entry(param_item, &devlink->param_list, list) + devlink_param_notify(devlink, 0, param_item, + DEVLINK_CMD_PARAM_NEW); } static void devlink_notify_unregister(struct devlink *devlink) { struct devlink_trap_policer_item *policer_item; struct devlink_trap_group_item *group_item; + struct devlink_param_item *param_item; struct devlink_trap_item *trap_item; struct devlink_port *devlink_port; struct devlink_rate *rate_node; struct devlink_region *region; - devlink_params_unpublish(devlink); + list_for_each_entry_reverse(param_item, &devlink->param_list, list) + devlink_param_notify(devlink, 0, param_item, + DEVLINK_CMD_PARAM_DEL); list_for_each_entry_reverse(region, &devlink->region_list, list) devlink_nl_region_notify(region, NULL, DEVLINK_CMD_REGION_DEL); @@ -10230,51 +10234,6 @@ void devlink_param_unregister(struct devlink *devlink, EXPORT_SYMBOL_GPL(devlink_param_unregister); /** - * devlink_params_publish - publish configuration parameters - * - * @devlink: devlink - * - * Publish previously registered configuration parameters. - */ -void devlink_params_publish(struct devlink *devlink) -{ - struct devlink_param_item *param_item; - - if (!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED)) - return; - - list_for_each_entry(param_item, &devlink->param_list, list) { - if (param_item->published) - continue; - param_item->published = true; - devlink_param_notify(devlink, 0, param_item, - DEVLINK_CMD_PARAM_NEW); - } -} -EXPORT_SYMBOL_GPL(devlink_params_publish); - -/** - * devlink_params_unpublish - unpublish configuration parameters - * - * @devlink: devlink - * - * Unpublish previously registered configuration parameters. - */ -void devlink_params_unpublish(struct devlink *devlink) -{ - struct devlink_param_item *param_item; - - list_for_each_entry(param_item, &devlink->param_list, list) { - if (!param_item->published) - continue; - param_item->published = false; - devlink_param_notify(devlink, 0, param_item, - DEVLINK_CMD_PARAM_DEL); - } -} -EXPORT_SYMBOL_GPL(devlink_params_unpublish); - -/** * devlink_param_driverinit_value_get - get configuration parameter * value for driver initializing * |