diff options
author | Keith Busch <kbusch@kernel.org> | 2020-05-08 13:04:06 -0700 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2020-05-12 18:02:24 +0200 |
commit | b69e2ef24b7b4867f80f47e2781e95d0bacd15cb (patch) | |
tree | 849b398f5ec603aa97bc6a1f6e387bfa90a7ba82 /scripts/bpf_helpers_doc.py | |
parent | 59c7c3caaaf8750df4ec3255082f15eb4e371514 (diff) |
nvme-pci: dma read memory barrier for completions
Control dependencies do not guarantee load order across the condition,
allowing a CPU to predict and speculate memory reads.
Commit 324b494c2862 inlined verifying a new completion with its
handling. At least one architecture was observed to access the contents
out of order, resulting in the driver using stale data for the
completion.
Add a dma read barrier before reading the completion queue entry and
after the condition its contents depend on to ensure the read order is
determinsitic.
Reported-by: John Garry <john.garry@huawei.com>
Suggested-by: Will Deacon <will@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Tested-by: John Garry <john.garry@huawei.com>
Acked-by: Will Deacon <will@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'scripts/bpf_helpers_doc.py')
0 files changed, 0 insertions, 0 deletions