diff options
author | ZhengYuan Liu <liuzhengyuan@kylinos.cn> | 2016-07-28 14:22:14 +0800 |
---|---|---|
committer | Shaohua Li <shli@fb.com> | 2016-08-01 20:18:21 -0700 |
commit | ff00d3b4e5e4395c825e8ec628f25932d812f31a (patch) | |
tree | b533f4994a7e780a5f3433869ea5da3f6fedf55b /tools/perf/scripts/python/call-graph-from-postgresql.py | |
parent | 9b622e2bbcf049c82e2550d35fb54ac205965f50 (diff) |
raid5: fix incorrectly counter of conf->empty_inactive_list_nr
The counter conf->empty_inactive_list_nr is only used for determine if the
raid5 is congested which is deal with in function raid5_congested().
It was increased in get_free_stripe() when conf->inactive_list got to be
empty and decreased in release_inactive_stripe_list() when splice
temp_inactive_list to conf->inactive_list. However, this may have a
problem when raid5_get_active_stripe or stripe_add_to_batch_list was called,
because these two functions may call list_del_init(&sh->lru) to delete sh from
"conf->inactive_list + hash" which may cause "conf->inactive_list + hash" to
be empty when atomic_inc_not_zero(&sh->count) got false. So a check should be
done at these two point and increase empty_inactive_list_nr accordingly.
Otherwise the counter may get to be negative number which would influence
async readahead from VFS.
Signed-off-by: ZhengYuan Liu <liuzhengyuan@kylinos.cn>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-postgresql.py')
0 files changed, 0 insertions, 0 deletions