summaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/exported-sql-viewer.py
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2020-04-24 20:14:10 +0100
committerChris Wilson <chris@chris-wilson.co.uk>2020-04-24 22:14:35 +0100
commit9669a5079995ddbe161243ca3e6cc86ca3ab6500 (patch)
treee764c31b231b6eff1684a586305912694a35c0d9 /tools/perf/scripts/python/exported-sql-viewer.py
parent9c878557b1ebd23316b65e4099313a4b0c21eac4 (diff)
drm/i915: Drop rq->ring->vma peeking from error capture
We only hold the active spinlock while dumping the error state, and this does not prevent another thread from retiring the request -- as it is quite possible that despite us capturing the current state, the GPU has completed the request. As such, it is dangerous to dereference state below the request as it may already be freed, and the simplest way to avoid the danger is not include it in the error state. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1788 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Andi Shyti <andi.shyti@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200424191410.27570-1-chris@chris-wilson.co.uk
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions