diff options
| author | Liam Girdwood <lrg@slimlogic.co.uk> | 2011-05-31 09:24:12 +0100 |
|---|---|---|
| committer | Andy Green <andy.green@linaro.org> | 2011-05-31 11:05:42 +0100 |
| commit | 60c84539202c4c2e5e263973e5700ba3928a5ad7 (patch) | |
| tree | 45e80a39ca7050459fb64a2aeb5c2e524dac625d /sound | |
| parent | b2e84bd82bb887f7cd874505aa54fa693aa903aa (diff) | |
Re: Panda mixer "AUX FM" mapping
Hi Andy,
On Mon, 2011-03-28 at 15:43 +0100, Andy Green wrote:
> Hi -
>
> Just a little issue I noticed, the operation of "Aux FM" slider in the
> current alsa stuff is a bit broken in terms of its mapping to the
> effective attenuation that happens.
>
> Starting at 0 everything is quiet, but as we go up it increases and
> decreases the volume in left and right individually. It's like it has
> the idea the attenuator is a single mono one where actually it's two
> smaller stereo ones.
>
> Also, Panda FM reception seems to work but with a headset lead as
> antenna, it's not what I would call reasonable signal quality. Is that
> anyone else's experience too?
>
> -Andy
I've just had a very quick check against the TRM and have attached an
untested patch (as my Panda is broken). Could you give this a try.
Liam
commit 3981b720b800bda16028f36ab10d2c9ec7e7c6c7
Author: Liam Girdwood <lrg@slimlogic.co.uk>
Date: Mon Mar 28 19:23:23 2011 +0100
ASoC: twl6040 - fix LINEGAIN volume control
Fix the TWL6040 LINEGAIN volume control to match the TRM.
Signed-off-by: Liam Girdwood <lrg@ti.com>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/twl6040.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c index 4ed2c1807bf..34fcfd46295 100644 --- a/sound/soc/codecs/twl6040.c +++ b/sound/soc/codecs/twl6040.c @@ -932,9 +932,9 @@ static DECLARE_TLV_DB_SCALE(mic_amp_tlv, -600, 600, 0); /* * AFMGAIN volume control: - * from 18 to 24 dB in 6 dB steps + * from -18 to 24 dB in 6 dB steps */ -static DECLARE_TLV_DB_SCALE(afm_amp_tlv, 1800, 600, 0); +static DECLARE_TLV_DB_SCALE(afm_amp_tlv, -1800, 600, 0); /* * HSGAIN volume control: @@ -1073,7 +1073,7 @@ static const struct snd_kcontrol_new twl6040_snd_controls[] = { /* AFM gains */ SOC_DOUBLE_TLV("Aux FM Volume", - TWL6040_REG_LINEGAIN, 0, 4, 0xF, 0, afm_amp_tlv), + TWL6040_REG_LINEGAIN, 0, 3, 7, 0, afm_amp_tlv), /* Playback gains */ SOC_TWL6040_DOUBLE_TLV("Headset Playback Volume", |